[PATCH 1/3] spi: bitbang: fix shift for getmosi
Michael Grzeschik
m.grzeschik at pengutronix.de
Wed Mar 12 11:53:35 EDT 2014
The driver needs to shift the word bit after reading the mosi bit.
Otherwise the return word will have an Off-by-one bit value.
Cc: <stable at vger.kernel.org>
Signed-off-by: Michael Grzeschik <m.grzeschik at pengutronix.de>
---
drivers/spi/spi-bitbang-txrx.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-bitbang-txrx.h b/drivers/spi/spi-bitbang-txrx.h
index c616e41..b6e348d 100644
--- a/drivers/spi/spi-bitbang-txrx.h
+++ b/drivers/spi/spi-bitbang-txrx.h
@@ -61,10 +61,10 @@ bitbang_txrx_be_cpha0(struct spi_device *spi,
spidelay(nsecs);
/* sample MSB (from slave) on leading edge */
- word <<= 1;
if ((flags & SPI_MASTER_NO_RX) == 0)
word |= getmiso(spi);
setsck(spi, cpol);
+ word <<= 1;
}
return word;
}
@@ -89,9 +89,9 @@ bitbang_txrx_be_cpha1(struct spi_device *spi,
spidelay(nsecs);
/* sample MSB (from slave) on trailing edge */
- word <<= 1;
if ((flags & SPI_MASTER_NO_RX) == 0)
word |= getmiso(spi);
+ word <<= 1;
}
return word;
}
--
1.9.0
More information about the linux-arm-kernel
mailing list