[PATCH 4/5] ARM: shmobile: r8a7790: add IIC(B) clocks to dtsi

[Magnus Damm]

Hi Wolfram,

On Wed, Mar 12, 2014 at 6:24 AM, Wolfram Sang <wsa at the-dreams.de> wrote:
> From: Wolfram Sang <wsa at sang-engineering.com>
>
> Signed-off-by: Wolfram Sang <wsa at sang-engineering.com>
> ---
> Note: Adding clocks whilst keeping the current sorting is very likely to
> break a previously working clock IMO. Imagine adding PCIEC clock inbetween IIC0
> and IIC1 here. Adding chronologically and grouped by similar function blocks is
> easier to track. An example addition could then look like:
>
>         R8A7790_CLK_TPU0
>         R8A7790_CLK_SDHI3 R8A7790_CLK_SDHI2 R8A7790_CLK_SDHI1 R8A7790_CLK_SDHI0
>         R8A7790_CLK_MMCIF1 R8A7790_CLK_MMCIF0
>         R8A7790_CLK_CMT1
>         R8A7790_CLK_IIC2 R8A7790_CLK_IIC1 R8A7790_CLK_IIC0
> +       R8A7790_CLK_PCIEC

Can you please care to explain a bit more about why you see a risk
here? Is it a risk for typo or something else?

It looks to me that this is just a matter about adding the entry at
the right position in several places.

Thanks,

/ magnus