Re: [PATCH v3][ 3/9] usb: chipidea: Use standard usb-phy property.

[Alexander Shiyan]

Среда, 12 марта 2014, 11:19 +01:00 от Lothar Waßmann <LW at KARO-electronics.de>:
> Hi,
> 
> Denis Carikli wrote:
> > This converts the Chipidea usbmisc driver to
> > use the standard usb-phy property.
> > 
> [...]
> > diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c
> > index c00f772..9a74100 100644
> > --- a/drivers/usb/chipidea/ci_hdrc_imx.c
> > +++ b/drivers/usb/chipidea/ci_hdrc_imx.c
> > @@ -130,7 +130,7 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
> >  		return ret;
> >  	}
> >  
> > -	data->phy = devm_usb_get_phy_by_phandle(&pdev->dev, "fsl,usbphy", 0);
> > +	data->phy = devm_usb_get_phy_by_phandle(&pdev->dev, "usb-phy", 0);
> >  	if (IS_ERR(data->phy)) {
> >  		ret = PTR_ERR(data->phy);
> >  		goto err_clk;
> >
> How about accepting the old property too and print a warning, that it is
> deprecated, rather than breaking all existing DT blobs?

And this change should be reflected in the bindings documentation.

---