Common clock: function clock and bus clock

Chao Xie xiechao.mail at gmail.com
Mon Mar 10 22:06:27 EDT 2014


hi

I can not find any examples for handling function clock and bus clock
in drivers/clk/.

For a device, it will have a function clock and bus clock. function
clock will control the fucntionality of this device, while bus clock
will control the communication part to the bus.

For some SOCes, they do not export bus clock, so from the hardware it
seems that function clock is combined with bus clock, while for some
SOCes, they are not.

For most of the device driver, they will enable/disable function clock
and bus clock both. While for some devices, they may share bus clock,
and have different function clocks.

In fact, i want to define the APIs as below:

struct clk* soc_register_bus_clock(struct device *dev, char **parent_name, ...);
This function will  create and register bus clock

struct clk* soc_register_fucntion_clock(struct device *dev, char
**parent_name, ...);
This function will create and register function clock

struct clk* soc_register_clk(struct device *dev, char **parent_name);
This function will create and register a device clock. Then this clock
is enable, it will enable bus clock and function clock both, and it is
similar for disabling.

struct clk* soc_register_composite_clk(struct device *dev, char
*bus_clk_name, char *function_clk_name);
This function will create and register a composite device clock. When
enable this clock, it will invoke clk_enable(bus_clk) and
clk_enable(function_clk) both. It is similar for disabling.

So for the device which has its own control register and bits for
function clock and bus clock. We can call  soc_register_clk.
For the device share bus clock with other devices, we create the clock
for the device by calling  soc_register_composite_clk.

1. Now clk_enable can be preempted by same caller.
2. For above devices, the bus clock only have enable/disable ops.

Based on above conditions, I think soc_register_composite_clk is fine.

Does anyone have same problems? Will above proposal break common clock rules.



More information about the linux-arm-kernel mailing list