[PATCH 2/4] documentaion: DT: allow a A5 compatible string in global timer

Rob Herring robherring2 at gmail.com
Mon Mar 10 13:57:32 EDT 2014


On Mon, Mar 10, 2014 at 11:51 AM, Mark Rutland <mark.rutland at arm.com> wrote:
> On Mon, Mar 10, 2014 at 04:27:09PM +0000, Rob Herring wrote:
>> On Mon, Mar 10, 2014 at 6:51 AM, Matthew Leach <matthew.leach at arm.com> wrote:
>> > The global timer is present on the Cortex A5. Add a compatibility
>> > string to the DT binding to allow a Cortex A5 global timer.
>> >
>> > Signed-off-by: Matthew Leach <matthew.leach at arm.com>
>> > ---
>> >  Documentation/devicetree/bindings/arm/global_timer.txt | 6 ++++--
>> >  1 file changed, 4 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/Documentation/devicetree/bindings/arm/global_timer.txt b/Documentation/devicetree/bindings/arm/global_timer.txt
>> > index 1e54898..0932891 100644
>> > --- a/Documentation/devicetree/bindings/arm/global_timer.txt
>> > +++ b/Documentation/devicetree/bindings/arm/global_timer.txt
>> > @@ -4,8 +4,10 @@
>> >
>> >  ** Timer node required properties:
>> >
>> > -- compatible : Should be "arm,cortex-a9-global-timer"
>> > -               Driver supports versions r2p0 and above.
>>
>> Shouldn't you keep this information for the A9?
>
> To me it feels like documenting the driver rather than the binding for
> the hardware.
>
> I'm happy to retain notes about the constraints imposed by Linux
> drivers, but I'd prefer if it were the exception rather than the rule.

Isn't the driver constraint based on the global timer h/w being broken
on pre r2p0? If it is truly a Linux limitation that could be fixed,
then I agree.

Rob



More information about the linux-arm-kernel mailing list