[PATCH] clk: hisilicon: fix warning from smatch
Zhangfei Gao
zhangfei.gao at linaro.org
Sun Mar 9 23:33:20 EDT 2014
drivers/clk/hisilicon/clk-hi3620.c:338
mmc_clk_delay() warn: always true condition '(para >= 0) => (0-u32max >= 0)'
Reported-by: Dan Carpenter <dan.carpenter at oracle.com>
Signed-off-by: Zhangfei Gao <zhangfei.gao at linaro.org>
---
drivers/clk/hisilicon/clk-hi3620.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/drivers/clk/hisilicon/clk-hi3620.c b/drivers/clk/hisilicon/clk-hi3620.c
index 38faa469d288..e75f742ca422 100644
--- a/drivers/clk/hisilicon/clk-hi3620.c
+++ b/drivers/clk/hisilicon/clk-hi3620.c
@@ -335,15 +335,14 @@ static u32 mmc_clk_delay(u32 val, u32 para, u32 off, u32 len)
{
u32 i;
- if (para >= 0) {
- for (i = 0; i < len; i++) {
- if (para % 2)
- val |= 1 << (off + i);
- else
- val &= ~(1 << (off + i));
- para = para >> 1;
- }
+ for (i = 0; i < len; i++) {
+ if (para % 2)
+ val |= 1 << (off + i);
+ else
+ val &= ~(1 << (off + i));
+ para = para >> 1;
}
+
return val;
}
--
1.7.9.5
More information about the linux-arm-kernel
mailing list