[PATCH] Disable Subpage nand write when using Atmel PMECC
Josh Wu
josh.wu at atmel.com
Thu Mar 6 22:59:46 EST 2014
Dear Herve
I add the Brian in the email, who is the maintainer of the mtd.
On 3/3/2014 7:15 PM, Herve Codina wrote:
> Crash detected on sam5d35 and its pmecc nand ecc controller.
>
> The problem was a call to chip->ecc.hwctl from nand_write_subpage_hwecc
> (nand_base.c) when we write a sub page.
> chip->ecc.hwctl function is not set when we are using PMECC controller.
> As a workaround, set NAND_NO_SUBPAGE_WRITE for PMECC controller in
> order to disable sub page access in nand_write_page.
>
>
> Signed-off-by: Herve Codina <Herve.CODINA at celad.com>
Acked-by: Josh Wu <josh.wu at atmel.com>
> ---
> drivers/mtd/nand/atmel_nand.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
> index 1f719e0..4ce181a 100644
> --- a/drivers/mtd/nand/atmel_nand.c
> +++ b/drivers/mtd/nand/atmel_nand.c
> @@ -1220,6 +1220,7 @@ static int atmel_pmecc_nand_init_params(struct platform_device *pdev,
> goto err;
> }
>
> + nand_chip->options |= NAND_NO_SUBPAGE_WRITE;
> nand_chip->ecc.read_page = atmel_nand_pmecc_read_page;
> nand_chip->ecc.write_page = atmel_nand_pmecc_write_page;
>
Best Regards,
Josh Wu
More information about the linux-arm-kernel
mailing list