Re: [PATCH v9][ 6/8] staging: imx-drm: parallel display: add regulator support.

[Alexander Shiyan]

Четверг,  6 марта 2014, 17:29 +01:00 от Philipp Zabel <p.zabel at pengutronix.de>:
> Hi Denis,
> 
> Am Donnerstag, den 06.03.2014, 17:04 +0100 schrieb Denis Carikli:
> > diff --git a/Documentation/devicetree/bindings/staging/imx-drm/fsl-imx-drm.txt b/Documentation/devicetree/bindings/staging/imx-drm/fsl-imx-drm.txt
> > index 2d24425..4dd7ce5 100644
> > --- a/Documentation/devicetree/bindings/staging/imx-drm/fsl-imx-drm.txt
> > +++ b/Documentation/devicetree/bindings/staging/imx-drm/fsl-imx-drm.txt
> > @@ -28,6 +28,7 @@ Required properties:
> >  - compatible: Should be "fsl,imx-parallel-display"
> >  - crtc: the crtc this display is connected to, see below
> >  Optional properties:
> > +- display-supply : phandle to the regulator device tree node if needed.
> 
> I'd very much prefer to not do this here. I have submitted a patch to
> add drm_display support to this driver, so you can connect a drm_panel
> compatible driver as output. The simple-panel driver already supports
> supply regulator and backlight control.
...
> > +	imxpd->disp_reg = devm_regulator_get(dev, "display");
> > +	if (IS_ERR(imxpd->disp_reg))
> > +		return PTR_ERR(imxpd->disp_reg);

And here we can see that this regulator is not optional.

---