[PATCH v2 6/6] PCI: designware: use new OF interrupt mapping when possible

Jason Gunthorpe jgunthorpe at obsidianresearch.com
Wed Mar 5 13:42:19 EST 2014


On Wed, Mar 05, 2014 at 02:25:51PM +0100, Lucas Stach wrote:
> -	return pp->irq;
> +	irq = of_irq_parse_and_map_pci(dev, slot, pin);
> +	if (!irq)
> +		irq = pp->irq;

In light of the two bugs that Tim found, it might be wise to throw a
'dev_warn(FW_BUG "Missing DT interrupt mapping")' in the fall back
path, so it doesn't continue to silently cover up errors on the OF/DT
side..

Regards,
Jason



More information about the linux-arm-kernel mailing list