[PATCH v2] ARM64: Kernel managed pages are only flushed
Bharat Bhushan
r65777 at freescale.com
Wed Mar 5 06:25:16 EST 2014
Kernel can only access pages which maps to managed memory.
So flush only valid kernel pages.
I observed kernel crash direct assigning a device using VFIO
and found that it was caused because of accessing invalid page
Signed-off-by: Bharat Bhushan <Bharat.Bhushan at freescale.com>
---
v1->v2
Getting pfn usin pte_pfn() in pfn_valid.
arch/arm64/mm/flush.c | 13 ++++++++++++-
1 files changed, 12 insertions(+), 1 deletions(-)
diff --git a/arch/arm64/mm/flush.c b/arch/arm64/mm/flush.c
index e4193e3..319826a 100644
--- a/arch/arm64/mm/flush.c
+++ b/arch/arm64/mm/flush.c
@@ -72,7 +72,18 @@ void copy_to_user_page(struct vm_area_struct *vma, struct page *page,
void __sync_icache_dcache(pte_t pte, unsigned long addr)
{
- struct page *page = pte_page(pte);
+ struct page *page;
+
+#ifdef CONFIG_HAVE_ARCH_PFN_VALID
+ /*
+ * We can only access pages that the kernel maps
+ * as memory. Bail out for unmapped ones.
+ */
+ if (!pfn_valid(pte_pfn(pte)))
+ return;
+
+#endif
+ page = pte_page(pte);
/* no flushing needed for anonymous pages */
if (!page_mapping(page))
--
1.7.0.4
More information about the linux-arm-kernel
mailing list