static asmlinkage in irqchip (was Re: next build: 78 warnings 0 failures (next/next-20140228))

Andi Kleen ak at linux.intel.com
Sat Mar 1 11:12:58 EST 2014


> These seem to be caused by 128ea04a9885 (lto: Make asmlinkage __visible,
> 2014-02-08). Before that change asmlinkage was defined to nothing on
> ARM, but now it's __visible. Should we just drop asmlinkage here?

These functions are just called by the generic C interrupt layer right?
Yes should just drop asmlinkage. It doesn't make any sense to mark
functions that only called from C asmlinkage.

Patch looks good to me.

-Andi



More information about the linux-arm-kernel mailing list