[PATCH] ARM: integrator: fix OF-related regression

Linus Walleij linus.walleij at linaro.org
Mon Jun 30 09:52:58 PDT 2014


On Thu, Jun 26, 2014 at 9:39 PM, Rabin Vincent <rabin at rab.in> wrote:

> earlyprintk doesn't work on Integrator hardware?

It does, but loading the kernel is done over serial line 115200 bps
so iterative tests take "some time" :-)

> It does on QEMU's
> integratorcp so it's trivial to debug there.

Yeah I should be using QEMU for things like this ... poke self.

> The problem is that integrator_init_sysfs() adds a device attribute
> called "fpga" to the soc0 bus, and the soc0 bus device is also used as
> the root of the device tree, and the device tree has a node called "fpga".
(...)
> 07e461cd7e73a84f0e3757932b93cc80976fd749 removed the .0 from the fpga node's
> directory, leading to that node (and its subnodes) failing to register due to a
> filename conflict with the fpga attribute's file:

Aha! Thanks for root-causing this Rabin. Awesome.

> After Linus' patch, the root is no longer soc0 so the fpga node's directory
> becomes /devices/fpga while the attribute file remains at /devices/soc0/fpga.

It appears the patch is doing the right thing, though I had very vague
ideas as to why.

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list