[PATCH] ARM: integrator: fix OF-related regression

Linus Walleij linus.walleij at linaro.org
Thu Jun 26 05:15:42 PDT 2014


On Wed, Jun 25, 2014 at 3:06 PM, Rob Herring <robherring2 at gmail.com> wrote:
> On Tue, Jun 24, 2014 at 7:08 AM, Linus Walleij <linus.walleij at linaro.org> wrote:
>> Commit 07e461cd7e73a84f0e3757932b93cc80976fd749
>> "of: Ensure unique names without sacrificing determinism"
>> caused a boot failure regression on the Integrator machines.
>>
>> The problem is probably caused by fiddling too much with
>> the device tree population in the OF init function, such
>> as passing the SoC bus device as parent when populating
>> the device tree.
>>
>> This patch fixes the problem by:
>>
>> - Avoiding to explicitly look up the tree root
>> - Look up devices needed before device population from
>>   the match only, passing NULL as root
>> - Passing NULL as root and parent when calling
>>   of_platform_populate()
>
> Just curious, I don't see how this fixes booting for Integrator. Where
> exactly does boot fail?

It fails by failing to populate the devicetree somehow. I don't
have the proper debugging needs, I just trial-and-horror-fixed
it by making the board init similar to other platforms :-/

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list