[PATCH v5 1/2] ARM: shmobile: r8a7790: add internal PCI bridge nodes

Magnus Damm magnus.damm at gmail.com
Wed Jun 25 20:53:14 PDT 2014


Hi Shimoda-san,

On Thu, Jun 26, 2014 at 12:37 PM, Yoshihiro Shimoda
<yoshihiro.shimoda.uh at renesas.com> wrote:
> Hi Magnus-san,
>
> (2014/06/26 12:01), Magnus Damm wrote:
>> Hi Shimoda-san,
>>
>> On Thu, Jun 26, 2014 at 11:47 AM, Yoshihiro Shimoda
>> <yoshihiro.shimoda.uh at renesas.com> wrote:
>>> Hi Sergei,
>>>
>>> (2014/06/25 2:59), Sergei Shtylyov wrote:
>>>> From: Ben Dooks <ben.dooks at codethink.co.uk>
>>>>
>>>> Add device nodes for the R8A7790 internal PCI bridge devices.
>>>>
>>>> Signed-off-by: Ben Dooks <ben.dooks at codethink.co.uk>
>>>> Reviewed-by: Ian Molton <ian.molton at codethink.co.uk>
>>>> [Sergei: added several properties to the PCI bridge nodes]
>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov at cogentembedded.com>
>>>
>>> Thank you for the patch!
>>> I tested this patch on my lager board and a usb memory, and it works.
>>>
>>> Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh at renesas.com>
>>
>> Thanks for testing. Just one quick question from my side: Which USB
>> port did you test?
>
> I tested usb ch1 only...
>
>> I somehow assumed that at least the majority of the USB ports on R-Car
>> Gen2 require a USB PHY device driver to work?
>
> Thank you for the point.
> About usb ch1, a USB PHY device driver doesn't need, I think.
> But, about ch0 and ch2, I think that they should require a USB PHY device driver.

Thanks for your clarification. It all makes sense now!

Cheers,

/ magnus



More information about the linux-arm-kernel mailing list