[PATCH v2] sched: Fix compiler warnings

David Laight David.Laight at ACULAB.COM
Wed Jun 25 08:40:28 PDT 2014


From: Guenter Roeck
> On 06/25/2014 07:49 AM, Uwe Kleine-Knig wrote:
> > Hello Guenter,
> >
> > On Wed, Jun 25, 2014 at 07:27:47AM -0700, Guenter Roeck wrote:
> >>> Maybe the author's intention was:
> >>>
> >>> 	static inline int cpu_corepower_flags(void) __attribute__((const));
> >>>
> >>> ?
> >>> This specifies that the function has no side effects and the return value
> >>> only depends on the (here non-existing) function arguments.
> >>>
> >>
> >> Possibly, but either I am missing something or this doesn't compile.
> > You need to do a separate declaration:
> >
> > 	static inline int cpu_corepower_flags(void) __attribute__((const));
> > 	static inline int cpu_corepower_flags(void)
> > 	{
> > 		...
> 
> Actually turns out one can use __attribute_const__, and it is
> 
> 	static inline int __attribute_const__ cpu_corepower_flags(void)
> 
> which turns out to be widely used.
> 
> I'll change that and resubmit after testing.

You don't need to tell the compiler that for an inline function.

	David



More information about the linux-arm-kernel mailing list