[PATCH v2 2/2] video: imxfb: Fix lcd_ops .set_power and .get_power on/off inversion

Denis Carikli denis at eukrea.com
Wed Jun 25 05:57:11 PDT 2014


On 06/25/2014 08:16 AM, Sascha Hauer wrote:
> You use IS_ERR_OR_NULL() here. imxfb_lcd_set_power uses IS_ERR(). One of
> both must be wrong.
Fixed by using IS_ERR_OR_NULL.

> You could reduce indentation by bailing out early:
>
> 	if (IS_ERR(fbi->lcd_pwr))
> 		return 0;
Fixed (with IS_ERR_OR_NULL).

Denis.



More information about the linux-arm-kernel mailing list