[PATCH v2 2/2] ARM: mvebu: Use system controller to get the soc id when possible

Andrew Lunn andrew at lunn.ch
Fri Jun 20 12:12:04 PDT 2014

> > +int mvebu_system_controller_get_soc_id(u32 *dev, u32 *rev)
> > +{
> > +	if (of_machine_is_compatible("marvell,armada38x") &&
> As Sergei commented on your documentation patch, we try to avoid
> wildcards in compatible strings.  Perhaps a match list would be more
> appropriate?

I'm being pedantic, but in this invocation, it is not a wildcard. It will
match one and only one compatible string.

However, we have the issue that 38x is not introduced in this patch,
it has been there for a while. So would you like another patch series
removing it from the DT files? A quick grep suggests nothing is using
"marvell,armada38x" except this patch. So it should not be a backwards
compatible issue.


More information about the linux-arm-kernel mailing list