[PATCH] pinctrl: st: Fix irqmux handler

Maxime COQUELIN maxime.coquelin at st.com
Fri Jun 20 04:34:54 PDT 2014

st_gpio_irqmux_handler() reads the status register to find out
which banks inside the controller have pending IRQs.
For each banks having pending IRQs, it calls the corresponding handler.

Problem is that current code restricts the number of possible banks inside the
controller to ST_GPIO_PINS_PER_BANK. This define represents the number of pins
inside a bank, so it shouldn't be used here.

On STiH407, PIO_FRONT0 controller has 10 banks, so IRQs pending in the two
last banks (PIO18 & PIO19) aren't handled.

This patch replace ST_GPIO_PINS_PER_BANK by the number of banks inside the

Cc: Srinivas Kandagatla <srinivas.kandagatla at linaro.org>
Cc: Linus Walleij <linus.walleij at linaro.org>
Cc: <stable at vger.kernel.org> #v3.15+
Signed-off-by: Maxime Coquelin <maxime.coquelin at st.com>
 drivers/pinctrl/pinctrl-st.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
index 1bd6363bc9..9f43916 100644
--- a/drivers/pinctrl/pinctrl-st.c
+++ b/drivers/pinctrl/pinctrl-st.c
@@ -1431,7 +1431,7 @@ static void st_gpio_irqmux_handler(unsigned irq, struct irq_desc *desc)
 	status = readl(info->irqmux_base);
-	for_each_set_bit(n, &status, ST_GPIO_PINS_PER_BANK)
+	for_each_set_bit(n, &status, info->nbanks)
 	chained_irq_exit(chip, desc);

More information about the linux-arm-kernel mailing list