[PATCH v3 2/2] ata: Fix the dma state machine lockup for the IDENTIFY DEVICE PIO mode command.
tj at kernel.org
Thu Jun 19 07:33:51 PDT 2014
On Thu, Jun 19, 2014 at 07:57:33PM +0530, Suman Tripathi wrote:
> [suman] : Are you ok if I make ahci_qc_issue in the ahci.h as not static
> and make it as EXPORT_SYMBOL_GPL ? Currenty ahci_qc_issue is static.
> If you take the current case , I only had to make ahci_sw_activity as non
> static and use it. So both the intention is same.
Yeah, sure. We end up having to export a function anyway. Better to
avoid duplicating the function body.
> So, it's just ATA_CMD_ID_ATA and ATA_CMD_ID_ATAPI is okay? That's
> kinda weird.
> [suman] : Not tested for ATA_CMD_ID_ATAPI. It's just for ATA_CMD_ID_ATA for
Can you give it a test? The two commands are really similar, so it'd
be surprising if the controller only chokes on one of them. Another
thing worthwhile testing is "libata.force=noncq,pio0" so that you can
be sure other pio commands are okay.
More information about the linux-arm-kernel