[PATCH RFC 1/2] libahci_platform: add ahci_platform_get_of_property

[zhangfei]

On 06/18/2014 03:37 PM, Lothar Waßmann wrote:
> Hi,
>
> Zhangfei Gao wrote:
>> Instead of setting hflags in different files,
>> ahci_platform_get_of_property set hpriv->flags when ahci_platform_init_host
>> according to property in dts.
>>
>> Signed-off-by: Zhangfei Gao <zhangfei.gao at linaro.org>
>> ---
>>   .../devicetree/bindings/ata/ahci-platform.txt      |    9 +++++
>>   drivers/ata/libahci_platform.c                     |   39 ++++++++++++++++++++
>>   2 files changed, 48 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/ata/ahci-platform.txt b/Documentation/devicetree/bindings/ata/ahci-platform.txt
>> index c96d8dcf98fd..c0b9f6e76ba4 100644
>> --- a/Documentation/devicetree/bindings/ata/ahci-platform.txt
>> +++ b/Documentation/devicetree/bindings/ata/ahci-platform.txt
>> @@ -26,6 +26,15 @@ Optional properties:
>>   - clocks            : must contain the sata, sata_ref and ahb clocks
>>   - clock-names       : must contain "ahb" for the ahb clock
>>
>> +- no-ncq: when present, controller can't do NCQ, turning off CAP_NCQ
>> +- 32bit-only: when present, controller can't do 64bit DMA, forcing 32bit
>> +- no-msi: when present, no PCI MSI
>> +- no-pmp: when present, controller can't do PMP, turning off CAP_PMP
>> +- yes-ncq: when present,controller can do NCQ, turning on CAP_NCQ
>> +- no-suspend: when present, controller can't do suspend
>> +- yes-fbs: when present, controller can do FBS, turning on CAP_FBS
>> +- no-fbs: when present, controller can't do FBS, turning off CAP_FBS
>> +
> 'yes-...' sounds a bit silly to me.
> What about 'force-...'?

Yes, good idea, thanks for the suggestion.

> That's also what the comment to the flag definitions in
> drivers/ata/ahci.h says:
> |AHCI_HFLAG_YES_NCQ              = (1 << 9), /* force NCQ cap on */
> |AHCI_HFLAG_YES_FBS              = (1 << 14), /* force FBS cap on */
>
>
> Lothar Waßmann
>