[PATCH] ARM: mvebu: select ARM_CPU_SUSPEND for Marvell EBU v7 platforms
ezequiel.garcia at free-electrons.com
Tue Jun 17 17:22:11 PDT 2014
On 11 Jun 02:06 PM, Thomas Petazzoni wrote:
> On Marvell Armada platforms, the PMSU (Power Management Service Unit)
> controls a number of power management related activities, needed for
> things like suspend/resume, CPU hotplug, cpuidle or even simply SMP.
> Since cpuidle support was added for Armada XP, the pmsu.c file in
> arch/arm/mach-mvebu/ calls the cpu_suspend() and cpu_resume() ARM
> functions, which are only available when
> CONFIG_ARM_CPU_SUSPEND=y. Therefore, configurations that have
> CONFIG_ARM_CPU_SUSPEND disabled due to PM_SLEEP being disabled no
> longer build properly, due to undefined references to cpu_suspend()
> and cpu_resume().
> To fix this, this patch simply ensures CONFIG_ARM_CPU_SUSPEND is
> always enabled for Marvell EBU v7 platforms. Doing things in a more
> fine-grained way would require a lot of #ifdef-ery in pmsu.c to
> isolate the parts that use cpu_suspend()/cpu_resume(), and those parts
> would anyway have been needed as soon as either one of suspend/resume,
> CPU hotplug or cpuidle was enabled.
> Reported-by: Ezequiel Garcia <ezequiel.garcia at free-electrons.com>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
> Jason, this patch is against the mvebu/soc branch, and should be
> pushed to 3.16, where the problem was introduced.
Acked-by: Ezequiel Garcia <ezequiel.garcia at free-electrons.com>
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
More information about the linux-arm-kernel