[PATCH 01/14] ARM: mvebu: fix randconfig builds for pmsu driver

Arnd Bergmann arnd at arndb.de
Tue Jun 17 08:20:22 PDT 2014


On Tuesday 17 June 2014 17:17:00 Thomas Petazzoni wrote:
> 
> > > This unfortunately isn't really correct, and the patch I sent in
> > > "[PATCH] ARM: mvebu: select ARM_CPU_SUSPEND for Marvell EBU v7
> > > platforms" on June, 11th already fixes the cpu_suspend()/cpu_resume()
> > > problem.
> > 
> > ok.
> > 
> > > The issue with your solution is that it assumes this function is only
> > > used for cpuidle. That is indeed the case in v3.16, but will be wrong
> > > as soon as we add CPU hotplug support, which I have posted on May, 30th
> > > in "[PATCH 0/5] CPU hotplug for Marvell Armada XP", and which I hope to
> > > see included in v3.17.
> > 
> > Right. I'll drop this patch from the submission then. You came just in
> > time, as I had originally planned to send it out this morning.
> > 
> > I'll also follow up with a separate patch to address the isb() issue.
> 
> Ok, thanks a lot!
> 
> So, should my patch adding the "select ARM_CPU_SUSPEND" be taken by
> Jason and then pushed to you, or will you apply it directly?

I'll wait for Jason to pick it up. It was clearly a mistake for me
to include my own patch directly and without an explicit Ack, I'll go
back to the normal way of doing things ;-)

	ARnd



More information about the linux-arm-kernel mailing list