[PATCH] mmc: implement driver stage register handling
Russell King - ARM Linux
linux at arm.linux.org.uk
Mon Jun 16 04:48:06 PDT 2014
On Mon, Jun 16, 2014 at 01:36:38PM +0200, Ulf Hansson wrote:
> On 23 May 2014 15:34, Sascha Hauer <s.hauer at pengutronix.de> wrote:
> > @@ -970,6 +971,9 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr,
> > goto free_card;
> > }
> > + if (card->csd.dsr_imp && (host->dsr & 0xffff) == host->dsr)
> To clarify, maybe add an extra pair of parentheses around the above expression?
To which I say, don't you bloody dare. It's perfectly readable as it
is, it doesn't need any additional parenthesis.
Additional useless parenthesis detracts from readability. Don't encourage
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
More information about the linux-arm-kernel