[PATCH v3 2/2] drm/panel: make DRM_PANEL_LD9040 depend on SPI
Thierry Reding
thierry.reding at gmail.com
Fri Jun 13 06:17:58 PDT 2014
On Fri, Jun 13, 2014 at 02:06:16PM +0100, Russell King wrote:
> Rather than DRM_PANEL_LD9040 selecting SPI, which then results in an
> increase in the probability of Kconf reporting circular dependencies
> (we're one "select" away from that right now), make this depend on
> SPI instead. This is akin to having some driver select DRM.
>
> Having some drivers depend on a subsystem, and other drivers select a
> subsystem is a recipe for circular dependencies, and there's really no
> need for it.
>
> The potential circular dependency (which can be caused today by the
> addition of selecting DRM_PANEL from DRM_IMX_LDB) is:
>
> symbol DMADEVICES is selected by SAMSUNG_DMADEV
> symbol SAMSUNG_DMADEV is selected by S3C64XX_PL080
> symbol S3C64XX_PL080 is selected by SPI_S3C64XX
> symbol SPI_S3C64XX depends on SPI
> symbol SPI is selected by DRM_PANEL_LD9040
> symbol DRM_PANEL_LD9040 depends on DRM_PANEL
> symbol DRM_PANEL is selected by DRM_IMX_LDB
> symbol DRM_IMX_LDB depends on MFD_SYSCON
> symbol MFD_SYSCON is selected by POWER_RESET_KEYSTONE
> symbol POWER_RESET_KEYSTONE depends on POWER_SUPPLY
> symbol POWER_SUPPLY is selected by HID_SONY
> symbol HID_SONY depends on NEW_LEDS
> symbol NEW_LEDS is selected by BACKLIGHT_ADP8860
> symbol BACKLIGHT_ADP8860 depends on BACKLIGHT_CLASS_DEVICE
> symbol BACKLIGHT_CLASS_DEVICE is selected by FB_MX3
> symbol FB_MX3 depends on MX3_IPU
> symbol MX3_IPU depends on DMADEVICES
>
> Acked-by: Arnd Bergmann <arnd at arndb.de>
> Signed-off-by: Russell King <rmk+kernel at arm.linux.org.uk>
> ---
> drivers/gpu/drm/panel/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied, thanks.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140613/db7bb3c9/attachment.sig>
More information about the linux-arm-kernel
mailing list