[RFC v2 1/3] Mailbox: Add support for ACPI
Ashwin Chaugule
ashwin.chaugule at linaro.org
Thu Jun 12 10:14:17 PDT 2014
On 12 June 2014 13:02, Arnd Bergmann <arnd at arndb.de> wrote:
> On Thursday 12 June 2014 12:48:10 Ashwin Chaugule wrote:
>>
>> +#ifndef CONFIG_ACPI
>> if (!mbox->of_xlate)
>> mbox->of_xlate = of_mbox_index_xlate;
>> -
>> +#endif
>> mutex_lock(&con_mutex);
>> list_add_tail(&mbox->node, &mbox_cons);
>> mutex_unlock(&con_mutex);
>>
>
> You can't do #ifndef here, the driver must still work if
> both OF and ACPI are enabled.
Ok. Here we could skip the macro altogether, since of_xlate wont be
called with ACPI anyway.
Will need to look into using/faking mbox->dev to remove the other ifndefs.
Cheers,
Ashwin
More information about the linux-arm-kernel
mailing list