[PATCH] ARM: Exynos : Fix build error with thumb2
kgene.kim at samsung.com
Wed Jun 11 08:13:53 PDT 2014
On 06/04/14 17:07, Santosh Shukla wrote:
> On 2 June 2014 15:40, Dave Martin<Dave.Martin at arm.com> wrote:
>> On Mon, May 26, 2014 at 09:23:45PM +0530, Santosh Shukla wrote:
>>> From: santosh shukla<santosh.shukla at linaro.org>
>>> Add non-global symbol .LLl2x0_regs_phys to avoid build break in thumb2 mode.
>>> IIUC, arm assembler fail to load value of "global" variable
>>> l2xo_regs_phys for thum2 mode and wrapping it in non-global symbol like
>>> .Ll2x0_regs_phys solves the build break issue.
>>> arch/arm/mach-exynos/sleep.S: Assembler messages:
>>> arch/arm/mach-exynos/sleep.S:57: Error: invalid immediate for address
>>> calculation (value = 0x00000004)
>>> fix inspired from 
>>>  https://lkml.org/lkml/2010/3/31/235
>>> Signed-off-by: santosh shukla<santosh.shukla at linaro.org>
>> Reviewed-by: Dave Martin<Dave.Martin at arm.com>
> Hi Kukjin, if this patch ok with you then can you pick it up.
Sure, I've applied this into fixes for 3.16.
>> The binutils folks insist that this is not a bug in gas. (I disagreed, but
>> it's a grey area.) This is the established pattern for working round this
>> issue -- looks fine to me.
More information about the linux-arm-kernel