[PATCH] serial: samsung: fix typo in debug code

Joe Perches joe at perches.com
Wed Jun 4 18:20:41 PDT 2014


On Tue, 2014-06-03 at 11:53 +0200, Arnd Bergmann wrote:
> commit e4ac92df2791 ("serial: samsung: Neaten dbg uses") introduced
> a regression in the conversion from vsprintf to vsnprintf.
> 
> This fixes the build error by passing the correct variable name.
> 
> Signed-off-by: Arnd Bergmann <arnd at arndb.de>
> Cc: Joe Perches <joe at perches.com>
> Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> Cc: Doug Anderson <dianders at chromium.org>
> Cc: Kukjin Kim <kgene.kim at samsung.com>
> 
> diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
> index 3293377..c1d3ebd 100644
> --- a/drivers/tty/serial/samsung.c
> +++ b/drivers/tty/serial/samsung.c
> @@ -66,7 +66,7 @@ static void dbg(const char *fmt, ...)
>  	char buff[256];
>  
>  	va_start(va, fmt);
> -	vscnprintf(buff, sizeof(buf), fmt, va);
> +	vscnprintf(buff, sizeof(buff), fmt, va);
>  	va_end(va);
>  
>  	printascii(buff);

Greg?

The original has ended up in Linus' -next branch.

Can you please apply this sooner rather than later?

Sorry for the bother.  Dunno how it happened.

I thought I compiled it with the appropriate CONFIG
settings.





More information about the linux-arm-kernel mailing list