[PATCH 0/4] arm:dma-mapping Refactoring iommu dma-mapping code
will.deacon at arm.com
Tue Jun 3 06:01:56 PDT 2014
On Mon, Jun 02, 2014 at 11:19:19AM +0100, ritesh.harjani at gmail.com wrote:
> From: Ritesh Harjani <ritesh.harjani at gmail.com>
> Hi All,
Thanks for the new patches. I have a few comments on the series as a whole.
> This patch series is to refractor iommu related common code from
> arch/arm/dma-mapping.c to lib/iommu-helper.c based on the various
> discussions with the maintainers/experts .
> Currently the only user of the common lib/iommu-helper code will
> be ARM & ARM64 but later various architecture might try to use this
> iommu lib helper functions.
> Major change of this refactoring starts with bringing out struct dma_iommu_mapping
> *mapping variable from arch/arm/include/asm/device.h to include/linux/device.h
> and by moving out complete structure defination of dma_iommu_mapping to
> inclue/linux/iommu-helper.h. Link  give more details on why this was done,
> also this change got approval from Will Daecon .
Well, I can't approve changes to include/linux/device.h, so that probably
needs to be acked by Grant and/or Greg. Could you split that patch out into
a separate change please, so that it can go in independently?
Also, I think you could merge patches 2 and 3, no?
> There are 1/2 more function definitions which I can think of moving out, but
> those can be done once this patch series is approved as those are not very
> big changes.
This certainly looks good to start with, although I think you should
consider renaming the functions in the helper library so that they aren't
prefixed with double underscores. Maybe iommu_helper_* instead?
Finally, please drop the ChangeId entries from your commit messages (and
you've consistently misspelled refactor as refractor).
More information about the linux-arm-kernel