[PATCH 06/14] irqchip: crossbar: fix memory leak incase of invalid entry
Sricharan R
r.sricharan at ti.com
Tue Jun 3 00:42:58 PDT 2014
From: Nishanth Menon <nm at ti.com>
When the provided unused skip list entry is greater than max irqs
possible, we go to err3, but we fail to free register_offsets,
should have returned to err4 instead which ensures that allocated
register_offsets are freed as well.
Signed-off-by: Nishanth Menon <nm at ti.com>
---
drivers/irqchip/irq-crossbar.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
index 42a2e62..fea3e5d 100644
--- a/drivers/irqchip/irq-crossbar.c
+++ b/drivers/irqchip/irq-crossbar.c
@@ -225,7 +225,7 @@ static int __init crossbar_of_init(struct device_node *node,
if (entry > max) {
pr_err("Invalid skip entry\n");
- goto err3;
+ goto err4;
}
cb->irq_map[entry] = IRQ_SKIP;
}
--
1.7.9.5
More information about the linux-arm-kernel
mailing list