[PATCH v4 3/4] ARM: dts: Clean up exynos5250-snow
Tomasz Figa
tomasz.figa at gmail.com
Thu Jul 31 12:19:35 PDT 2014
Andreas,
Please see my comments inline.
On 31.07.2014 18:08, Andreas Färber wrote:
> Use the new style of referencing inherited nodes and use symbolic names.
>
> Suggested-by: Doug Anderson <dianders at chromium.org>
> Signed-off-by: Andreas Färber <afaerber at suse.de>
[snip]
> -
> usb at 12110000 {
> - samsung,vbus-gpio = <&gpx1 1 0>;
> + samsung,vbus-gpio = <&gpx1 1 GPIO_ACTIVE_HIGH>;
> };
This is a higher level node being overridden, so it should be specified
using references too.
>
> fixed-rate-clocks {
> @@ -287,7 +206,7 @@
> };
>
> hdmi {
Ditto.
Best regards,
Tomasz
More information about the linux-arm-kernel
mailing list