[PATCH v9 6/6] clk: samsung: remove unused clock aliases and update clock flags

Tomasz Figa tomasz.figa at gmail.com
Thu Jul 31 07:13:46 PDT 2014


On 30.07.2014 10:07, Thomas Abraham wrote:
> With some of the Exynos SoCs switched over to use the generic CPUfreq drivers,
> the unused clock aliases can be removed. In addition to this, the individual
> clock blocks which are now encapsulated with the consolidate CPU clock type
> can now be marked with read-only flags.

[snip]

> @@ -1500,6 +1499,7 @@ static void __init exynos4_clk_init(struct device_node *np,
>  		exynos4_soc == EXYNOS4210 ? "Exynos4210" : "Exynos4x12",
>  		_get_rate("sclk_apll"),	_get_rate("sclk_mpll"),
>  		_get_rate("sclk_epll"), _get_rate("sclk_vpll"),
> +		exynos4_soc == EXYNOS4210 ? _get_rate("armclk") :
>  		_get_rate("div_core2"));

I believe "div_core2" should work fine here for all SoCs without the
need for this if.

>  }
>  
> diff --git a/drivers/clk/samsung/clk-exynos5250.c b/drivers/clk/samsung/clk-exynos5250.c
> index e19e365..1d958f1 100644
> --- a/drivers/clk/samsung/clk-exynos5250.c
> +++ b/drivers/clk/samsung/clk-exynos5250.c

[snip]

> @@ -848,6 +851,6 @@ static void __init exynos5250_clk_init(struct device_node *np)
>  	samsung_clk_of_add_provider(np, ctx);
>  
>  	pr_info("Exynos5250: clock setup completed, armclk=%ld\n",
> -			_get_rate("div_arm2"));
> +			_get_rate("armclk"));

Similarly here, no need for this change.

Best regards,
Tomasz



More information about the linux-arm-kernel mailing list