[PATCH v2 1/2] ARM: smp_scu: use macro for SCU enable bit

Sören Brinkmann soren.brinkmann at xilinx.com
Wed Jul 30 08:40:52 PDT 2014


Hi Shawn,

On Fri, 2014-07-25 at 04:09PM +0800, Shawn Guo wrote:
> Use macro instead of magic number for SCU enable bit.
> 
> Signed-off-by: Shawn Guo <shawn.guo at freescale.com>
> ---
>  arch/arm/kernel/smp_scu.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/kernel/smp_scu.c b/arch/arm/kernel/smp_scu.c
> index 1aafa0d785eb..c947508f84e6 100644
> --- a/arch/arm/kernel/smp_scu.c
> +++ b/arch/arm/kernel/smp_scu.c
> @@ -17,6 +17,7 @@
>  #include <asm/cputype.h>
>  
>  #define SCU_CTRL		0x00
> +#define SCU_ENABLE		(1 << 0)
I'd prefer using 'BIT(0)' here (and accordingly in the second patch).

For both patches:
Acked-by: Soren Brinkmann <soren.brinkmann at xilinx.com>

	Sören



More information about the linux-arm-kernel mailing list