[RFC 4/5] regulator: tps65090: Set voltage for fixed regulators

Javier Martinez Canillas javier.martinez at collabora.co.uk
Wed Jul 30 01:55:59 PDT 2014

On 07/29/2014 07:36 PM, Mark Brown wrote:
> On Tue, Jul 29, 2014 at 06:28:58PM +0200, Javier Martinez Canillas wrote:
>> +#define tps65090_REG_VAR(_id, _sname, en_reg, _en_bits, _ops) \
>> +	tps65090_REG_DESC(_id, _sname, en_reg, _en_bits, 0, 0, _ops)
> I'd expect this to describe a variable regulator when in fact it
> seems it describes a switch with no regulation.  Better name please.

Yes, when writing the patch I thought of a switch as a non-fixed regulator whose
output voltage is variable and depend on its input supply voltage. That's why I
used VAR but I agree that is a bad name and I'll change it.

Thanks a lot and best regards,

More information about the linux-arm-kernel mailing list