[PATCH] arm64/crypto: fix makefile rule for aes-glue-%.o
ard.biesheuvel at linaro.org
Mon Jul 28 10:00:17 PDT 2014
On 27 July 2014 20:40, Sam Ravnborg <sam at ravnborg.org> wrote:
>> > Btw. the current solution is already faulty - even with the fix.
>> > There are no support for make C=2 arch/.../crypto/
>> So can you elaborate on how it is faulty?
> When you run "make C=2 arch/.../crypto/" then sparse shall be run
> for all .c files also if they are already built.
> But due to the re-implementation of some parts of the kbuild logic
> in the makefile this does not happen with the -glue file.
> A minor detail - but this may not be the only wreckage we see over time.
I agree. Any suggestions for a generic way to solve this? Perhaps
something like this in scripts/Makefile.build
template_rule = $(obj)/$(tmpl)%.c: $(src)/$(tmpl).c ; @cp $$(^) $$(@)
$(eval $(foreach tmpl,$(TEMPLATES),$(template_rule)))
so that arch/arm64/crypto/Makefile only has to define
TEMPLATES += aes-glue
so that all dependencies on aes-glueXXX.c are satisfied by aes-glue.c?
BTW, while looking into this issue, I noticed something else that is strange:
after touch'ing sha1-ce-glue.c in arch/arm64/crypto and re-executing
'make V=2', this is what I get
make: Entering directory `/home/ard/linux-arm64-build'
Using /home/ard/linux-2.6 as source for kernel
CALL /home/ard/linux-2.6/scripts/checksyscalls.sh - due to target missing
CC arch/arm64/crypto/sha1-ce-glue.o - due to:
LD arch/arm64/crypto/sha1-ce.o - due to: arch/arm64/crypto/sha1-ce-glue.o
LD arch/arm64/crypto/sha2-ce.o - due to: arch/arm64/crypto/sha1-ce-glue.o
LD arch/arm64/crypto/ghash-ce.o - due to:
LD arch/arm64/crypto/aes-ce-ccm.o - due to:
LD arch/arm64/crypto/built-in.o - due to:
LINK vmlinux - due to: arch/arm64/crypto/built-in.o
IOW, unrelated object files are detected as being out of date. (This
is after running make mrproper, and with the aes-glue-% related rules
and definitions commented out, just to make sure this is not related
to the issue you have identified)
More information about the linux-arm-kernel