[PATCH] arm: omap: hwmod: drop unnecessary list initialization
paul at pwsan.com
Sun Jul 27 22:24:34 PDT 2014
On Tue, 15 Jul 2014, Felipe Balbi wrote:
> ml->node and sl->node are currently initialized
> by means of INIT_LIST_HEAD(). That initialiation
> is followed by a list_add() call.
> Looking at what both these functions do we will have:
> ml->node.next = &ml->node;
> ml->node.prev = &ml->node;
> oi->master->master_ports.next.prev = &ml->node;
> ml->node.next = &oi->master->master_ports.next;
> ml->node.prev = &oi->master->master_ports;
> oi->master->master_ports.next = &ml->node;
> from this, it's clear that both INIT_LIST_HEAD() calls
> are unnecessary and can be safely removed.
> Signed-off-by: Felipe Balbi <balbi at ti.com>
> found by code inspection, boot tested on am437x SK on today's
> linux-next + pending patches.
Thanks, queued for v3.18.
More information about the linux-arm-kernel