next build: 629 warnings 1 failures (next/next-20140723)

[Olof Johansson]

On Thu, Jul 24, 2014 at 6:24 AM, Catalin Marinas
<catalin.marinas at arm.com> wrote:
> On Thu, Jul 24, 2014 at 11:43:18AM +0100, Catalin Marinas wrote:
>> On Thu, Jul 24, 2014 at 09:50:37AM +0100, Will Deacon wrote:
>> > On Thu, Jul 24, 2014 at 12:27:30AM +0100, Olof Johansson wrote:
>> > > I'm building with a vanilla gcc 4.8.2 / binutils 2.23.2. That
>> > > shouldn't be broken like this, so those changes should be fixed (or
>> > > minimal toolchain expecations need to be documented -- but there
>> > > really is no good reason to require 4.9.0/2.24).
>> >
>> > These all come from the GICv3 driver, so it's not going to be a lot of fun
>> > fixing them. You'd have to introduce a macro for generating the system-reg
>> > accesses (for both C and asm), then switch the GIC driver and the arch code
>> > over to using that.
>>
>> We may need to document that enabling GICv3 requires a newer toolchain.
>>
>> Otherwise, my years old macros ;) (adapted here and untested):
> [...]
>> But I'll let Marc comment when he gets back from holiday (I'm pretty
>> sure he will enjoy it ;))
>
> Saving Marc some time:
>
> ------------8<--------------------------------
>
> From 3acb8b49aeba9f48153a2d719dec05d0b862e285 Mon Sep 17 00:00:00 2001
> From: Catalin Marinas <catalin.marinas at arm.com>
> Date: Thu, 24 Jul 2014 14:14:42 +0100
> Subject: [PATCH] arm64: gicv3: Allow GICv3 compilation with older binutils
>
> GICv3 introduces new system registers accessible with the full msr/mrs
> syntax (e.g. mrs x0, Sx_op0_op1_CRm_CRn_op2). However, only recent
> binutils understand the new syntax. This patch introduces msr_s/mrs_s
> assembly macros which generate the equivalent instructions above and
> converts the existing GICv3 code (both drivers/irqchip/ and
> arch/arm64/kernel/).
>
> Signed-off-by: Catalin Marinas <catalin.marinas at arm.com>
> Suggested-by: Mark Rutland <mark.rutland at arm.com>
> Reported-by: Olof Johansson <olof at lixom.net>
> Cc: Will Deacon <will.deacon at arm.com>
> Cc: Marc Zyngier <marc.zyngier at arm.com>

Tested-by: Olof Johansson <olof at lixom.net>


Thanks!

-Olof