[PATCH 09/19] mfd: ezx-pcap: Repair coding style errors picked up with checkpatch
Lee Jones
lee.jones at linaro.org
Tue Jul 22 06:48:24 PDT 2014
On Tue, 22 Jul 2014, Joe Perches wrote:
> On Tue, 2014-07-22 at 12:11 +0100, Lee Jones wrote:
> > This is part of an effort to clean-up the MFD subsystem.
> >
> > WARNING: Missing a blank line after declarations
> > + u32 flags;
> > + void (*callback)(void *, u16[]);
>
> False positive from an old version of checkpatch.
>
> The one in -next doesn't emit this as it's
> simply a function pointer declaration.
Thanks Joe, will fix up.
> > diff --git a/drivers/mfd/ezx-pcap.c b/drivers/mfd/ezx-pcap.c
> []
> > @@ -25,8 +25,9 @@ struct pcap_adc_request {
> > u8 bank;
> > u8 ch[2];
> > u32 flags;
> > - void (*callback)(void *, u16[]);
> > void *data;
> > +
> > + void (*callback)(void *, u16[]);
> > };
>
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
More information about the linux-arm-kernel
mailing list