答复: [PATCH resend v2] arm64: dmi: Add SMBIOS/DMI support

[liyi 00215672]

Hi Will,

	You need to add the SMBIOS support in UEFI on JUNO ,then you will get some proper information from DMI driver.

	Thanks!

Yi

-----邮件原件-----
发件人: Will Deacon [mailto:will.deacon at arm.com] 
发送时间: 2014年7月21日 16:48
收件人: Ard Biesheuvel
抄送: Catalin Marinas; yi.li at linaro.org; liyi 00215672; grant.likely at linaro.org; leif.lindholm at linaro.org; linux-arm-kernel at lists.infradead.org; Mark Rutland
主题: Re: [PATCH resend v2] arm64: dmi: Add SMBIOS/DMI support

On Sun, Jul 20, 2014 at 11:25:34AM +0100, Ard Biesheuvel wrote:
> On 14 July 2014 15:57, Ard Biesheuvel <ard.biesheuvel at linaro.org> wrote:
> > On 14 July 2014 15:36, Will Deacon <will.deacon at arm.com> wrote:
> >> On Fri, Jul 11, 2014 at 12:46:50PM +0100, Ard Biesheuvel wrote:
> >>> From: Yi Li <yi.li at linaro.org>
> >>>
> >>> SMbios is important for server hardware vendors. It implements a spec for
> >>> providing descriptive information about the platform. Things like serial
> >>> numbers, physical layout of the ports, build configuration data, and the like.
> >>>
> >>> This has been tested by dmidecode and lshw tools.
> >>>
> >>> Signed-off-by: Yi Li <yi.li at linaro.org>
> >>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>
> >>> ---
> >>> Changes since previous version:
> >>> - changed double inclusion guard to arm64 flavour
> >>> - use kzalloc(GFP_KERNEL) as GFP_ATOMIC is not needed
> >>> - do a sanity check on the size of the requested mapping
> >>
> >> Technically, this patch looks fine to me:
> >>
> >>   Reviewed-by: Will Deacon <will.deacon at arm.com>
> >>
> 
> Hello Catalin,
> 
> This has been tested by Yi on FVP and Juno.
> Are you ok to take this?

Out of interest, how did you test it on Juno? I tried but got some messages
about missing/invalid DMI data or something similar. Leif reckons I need
some tricked out firmware for the FVP to get something working, but even
then the information is apparently bogus.

Will