[PATCH RFCv3 08/14] arm64: introduce aarch64_insn_gen_movewide()

David Laight David.Laight at ACULAB.COM
Wed Jul 16 09:25:35 PDT 2014


From: Will Deacon
...
> > +	BUG_ON(imm < 0 || imm > 65535);
> 
> Do this check with masking instead?

The compiler will convert that to a single unsigned comparison.

...
> > +		BUG_ON(shift != 0 && shift != 16 && shift != 32 &&
> > +		       shift != 48);

OTOH I don't think it will convert that to:
		BUG_ON(shift & ~48);

	David






More information about the linux-arm-kernel mailing list