[PATCH resend v2] arm64: dmi: Add SMBIOS/DMI support

Ard Biesheuvel ard.biesheuvel at linaro.org
Mon Jul 14 06:57:12 PDT 2014


On 14 July 2014 15:36, Will Deacon <will.deacon at arm.com> wrote:
> On Fri, Jul 11, 2014 at 12:46:50PM +0100, Ard Biesheuvel wrote:
>> From: Yi Li <yi.li at linaro.org>
>>
>> SMbios is important for server hardware vendors. It implements a spec for
>> providing descriptive information about the platform. Things like serial
>> numbers, physical layout of the ports, build configuration data, and the like.
>>
>> This has been tested by dmidecode and lshw tools.
>>
>> Signed-off-by: Yi Li <yi.li at linaro.org>
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>
>> ---
>> Changes since previous version:
>> - changed double inclusion guard to arm64 flavour
>> - use kzalloc(GFP_KERNEL) as GFP_ATOMIC is not needed
>> - do a sanity check on the size of the requested mapping
>
> Technically, this patch looks fine to me:
>
>   Reviewed-by: Will Deacon <will.deacon at arm.com>
>

Thanks.

> It would be good if somebody with a relevant platform could confirm that
> it works/is useful though.
>

The usefulness has been debated here a couple of times before:
Grant's take on it is here
http://marc.info/?l=linux-arm-kernel&m=140206407411522&w=2

As to whether it works: I have asked Yi to retest this version of the
patch with lshw and dmidecode
@Yi: could you please share your findings here?

-- 
Ard.



More information about the linux-arm-kernel mailing list