[PATCH V9 2/7] phy: Add drivers for PCIe and SATA phy on SPEAr13xx

Viresh Kumar viresh.kumar at linaro.org
Sun Jul 13 22:24:18 PDT 2014


On 14 July 2014 10:52, Mohit KUMAR DCG <Mohit.KUMAR at st.com> wrote:
> - I think we should read regmap_*() and msleep() in continuation and so the comment above it
> is valid for both the operations.

Probably not, its not obvious why a msleep() is required after regmap_*().

> Otherwise we can add comment line for msleep() like:
> /* Wait for SATA power domain on */
> /* Wait for SATA reset de-assert completion */
>
> Similarily in *_exit routine:
> /* Wait for SATA power domain off */
> /* Wait for SATA reset assert completion */

These makes sense. Will add them.



More information about the linux-arm-kernel mailing list