[alsa-devel] [PATCH 2/4] ASoC: s3c64xx/smartq: use dynamic registration
lars at metafoo.de
Sun Jul 13 06:36:52 PDT 2014
On 07/12/2014 09:49 PM, Mark Brown wrote:
> On Sat, Jul 12, 2014 at 05:27:59PM +0200, Lars-Peter Clausen wrote:
>> On 07/11/2014 03:45 PM, Arnd Bergmann wrote:
>>> As a prerequisite for moving s3c64xx into multiplatform configurations,
>>> we need to change the smartq audio driver to stop using hardcoded
>>> gpio numbers from the header file, and instead pass the gpio data
>>> through platform_data.
>> This should be using the gpiod API. The gpiod API allows you to pass the
>> GPIOs without having to add a platform_data struct.
> OTOH that's a more invasive change that's harder to do mechanically -
> I'm not sure it's sensible to insist on someone doing it for generic
> cleanups (rather than actively working with the particular platform).
I don't think it is more invasive than using platform data. I did the same
recently for jz4740 qi-lb60 and the changes in the patch are fairly trivial.
The non-descriptor API is deprecated, so this even if this patch is applied as
is sooner or later somebody will mechanically convert it to the descriptor API.
More information about the linux-arm-kernel