[PATCH 3/6] pinctrl: exynos: Consolidate irq_chips of GPIO and WKUP EINTs

Linus Walleij linus.walleij at linaro.org
Tue Jul 8 01:59:52 PDT 2014

On Wed, Jul 2, 2014 at 5:41 PM, Tomasz Figa <t.figa at samsung.com> wrote:

> Handling of irq_chip operations for GPIO and WKUP external interrupts
> is mostly the same, with the difference being offset of registers.
> However currently the driver has all the code duplicated for both EINT
> types, which is undesirable, because changes in irq_chip operations have
> to be done to both instances of the same code.
> This patch fixes this by creating exynos_irq_chip struct that has normal
> irq_chip struct embedded and contain differences between particular EINT
> types, which are three register offsets. One instance of code is removed
> and the new structure is used instead to fetch necessary data instead of
> samsung_pin_ctrl struct used previously.
> While at it, the patch removes Exynos-specific fields from
> aforementioned structure to improve layering of the driver.
> Signed-off-by: Tomasz Figa <t.figa at samsung.com>

Patch applied.

Linus Walleij

More information about the linux-arm-kernel mailing list