[PATCH] pinctrl: pinctrl-at91.c: Cleaning up values that are never used

Linus Walleij linus.walleij at linaro.org
Mon Jul 7 08:47:50 PDT 2014


On Thu, Jun 26, 2014 at 3:41 PM, Rickard Strandqvist
<rickard_strandqvist at spectrumdigital.se> wrote:

> Remove variable that are never used
>
> This was found using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist at spectrumdigital.se>
(...)
> -       int ret, val, num_conf = 0;
> +       int val, num_conf = 0;
>
> -       ret = at91_pinconf_get(pctldev, pin_id, &config);
> +       at91_pinconf_get(pctldev, pin_id, &config);

Hm I would have preferred a fix actually checking the ret value,
but the debug show doesn't allow failing, and it's just for
debug anyway...

Patch applied.

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list