drm/i2c: tda998x: Set CEC I2C address from TDA I2C address

Russell King - ARM Linux linux at arm.linux.org.uk
Wed Jul 2 03:25:13 PDT 2014


You missed me as the maintainer of the driver:

NXP TDA998X DRM DRIVER
M:      Russell King <rmk+kernel at arm.linux.org.uk>
S:      Supported
F:      drivers/gpu/drm/i2c/tda998x_drv.c
F:      include/drm/i2c/tda998x.h

On Wed, Jul 02, 2014 at 10:33:44AM +0100, Andrew Jackson wrote:
> @@ -1274,9 +1275,9 @@ tda998x_encoder_init(struct i2c_client *client,
> 
>         priv->current_page = 0xff;
>         priv->hdmi = client;
> -       priv->cec = i2c_new_dummy(client->adapter, 0x34);
> -       if (!priv->cec)
> -               priv->cec = i2c_new_dummy(client->adapter, 0x35);
> +       /* CEC I2C address bound to TDA998x I2C addr by configuration pins */
> +       cec_addr = 0x34 + (client->addr & 3);
> +       priv->cec = i2c_new_dummy(client->adapter, cec_addr);

We discussed the issue of the I2C CEC address when the DT binding first
came up...

Do we know for certain that the above is always true for all the devices
that this driver supports?

-- 
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.



More information about the linux-arm-kernel mailing list