[PATCH v5 04/14] clk: max77686: Improve Maxim 77686 PMIC clocks binding
Javier Martinez Canillas
javier.martinez at collabora.co.uk
Wed Jul 2 03:17:54 PDT 2014
Hello Mike,
On 07/01/2014 07:29 PM, Mike Turquette wrote:
> Quoting Javier Martinez Canillas (2014-06-26 11:15:36)
>> Like most clock drivers, the Maxim 77686 PMIC clock binding
>> follows the convention that the "#clock-cells" property is
>> used to specify the number of cells in a clock provider.
>>
>> But the binding document is not clear enough that it shall
>> be set to 1 since the PMIC support multiple clocks outputs.
>>
>> Also, explain that the clocks identifiers are defined in a
>> header file that can be included by Device Tree source with
>> client nodes to avoid using magic numbers.
>>
>> Signed-off-by: Javier Martinez Canillas <javier.martinez at collabora.co.uk>
>> Reviewed-by: Krzysztof Kozlowski <k.kozlowski at samsung.com>
>> Reviewed-by: Doug Anderson <dianders at chromium.org>
>
> Looks good to me.
>
> Regards,
> Mike
>
Thanks a lot, an Acked-by or Reviewed-by tags for this patch and 03/14 will be
great as well so I can carry those on the next version of the series.
Best regards,
Javier
More information about the linux-arm-kernel
mailing list