[PATCH v2 4/5] efi: efistub: refactor stub components

Matt Fleming matt at console-pimps.org
Tue Jul 1 09:22:21 PDT 2014


On Tue, 01 Jul, at 05:20:21PM, Ard Biesheuvel wrote:
> 
> ... but that wasn't your question ....
> 
> The reason this can't live in "efistub.h" is that it gets included by
> bits under arch/xxx
> So perhaps moving the local "efistub.h" to <linux/efistub.h> would be
> appropriate, yes.

I didn't mean that we should add include/linux/efistub.h, rather that we
should try adding them to efistub.h or asm/efi.h.

But I see that isn't going to work too well and there's no easy fix.
Let's just leave things as they are for now.

Long term, I've been thinking of splitting up include/linux/efi.h. It's
currently weighing in at 1208 lines and contains pieces for all sorts of
different chunks of EFI code, 32-bit and 64-bit versions of data
structures, etc.

-- 
Matt Fleming, Intel Open Source Technology Center



More information about the linux-arm-kernel mailing list