[PATCHv5 05/15] hwspinlock/omap: add support for dt nodes
Ohad Ben-Cohen
ohad at wizery.com
Tue Jul 1 05:48:59 PDT 2014
Hi Suman,
On Thu, May 1, 2014 at 3:34 AM, Suman Anna <s-anna at ti.com> wrote:
> static int omap_hwspinlock_probe(struct platform_device *pdev)
> {
> - struct hwspinlock_pdata *pdata = pdev->dev.platform_data;
> + struct device_node *node = pdev->dev.of_node;
> struct hwspinlock_device *bank;
> struct hwspinlock *hwlock;
> struct resource *res;
> void __iomem *io_base;
> int num_locks, i, ret;
> + int base_id = 0;
We shouldn't implicitly assume base_id is zero: let's explicitly
protect against potential subsequent invocations of
omap_hwspinlock_probe.
Thanks,
Ohad.
More information about the linux-arm-kernel
mailing list