[PATCH v2] ARM: iop32x: fix power off handling for the EM7210 board

Linus Walleij linus.walleij at linaro.org
Thu Jan 30 03:56:17 EST 2014

On Thu, Jan 30, 2014 at 12:19 AM, Arnaud Patard
<arnaud.patard at rtp-net.org> wrote:
> Linus Walleij <linus.walleij at linaro.org> writes:

>>  void em7210_power_off(void)
>>  {
>> -     *IOP3XX_GPOE &= 0xfe;
>> -     *IOP3XX_GPOD |= 0x01;
>> +     int ret;
>> +
>> +     ret = gpio_direction_output(EM7210_HARDWARE_POWER, 1);
> btw, any reason for not using gpio_direction_output() in
> em7210_request_gpios() and gpio_set_value() here ? (just wondering)

Mainly because the old code did not drive a default value on
the pin (which would be zero then) but relies on the power-on

So by not doing this I'm not poking any hardware that wasn't poked

> I can't test it on my ss4000e but at least this patch looks fine.

Would be nice!

Linus Walleij

More information about the linux-arm-kernel mailing list