[PATCH 2/2] clk: exynos4: Fix spacing related checkpatch errors

Sachin Kamat sachin.kamat at linaro.org
Fri Jan 24 04:07:59 EST 2014


Hi Tomasz,

On 20 January 2014 17:37, Tomasz Figa <t.figa at samsung.com> wrote:
> Hi Sachin,
>
>
> On 15.01.2014 11:01, Sachin Kamat wrote:
>>
>> Silences the following type of checkpatch errors:
>> ERROR: space prohibited after that open parenthesis '('
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat at linaro.org>
>> ---
>>   drivers/clk/samsung/clk-exynos4.c |   50
>> ++++++++++++++++++-------------------
>>   1 file changed, 25 insertions(+), 25 deletions(-)
>
>
> I believe this is a false warning. In this special case the spaces greatly
> improve readability of static data in the driver, which I believe is
> preferred over the strict rules of checkpatch.

I agree that the existing pattern looks good to eyes :)
But then you will keep getting many such fix patches. The intention was to
bring this to your notice.
What say about the other patch in this series?

-- 
With warm regards,
Sachin



More information about the linux-arm-kernel mailing list